-
Notifications
You must be signed in to change notification settings - Fork 264
Support Plugin Arguments #639
Support Plugin Arguments #639
Conversation
@@ -49,4 +49,6 @@ type PluginOption struct { | |||
PredicateDisabled bool `yaml:"disablePredicate"` | |||
// NodeOrderDisabled defines whether NodeOrderFn is disabled | |||
NodeOrderDisabled bool `yaml:"disableNodeOrder"` | |||
// Arguments defines the different arguments that can be given to different plugins | |||
Arguments map[string]string `yaml:"arguments"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to pass the arguments to plugins: update plugin's New
to New(args map[string]string)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have made those changes
/lgtm please one another PR for weight in |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, thandayuthapani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…9-upstream-release-0.4 Automated cherry pick of #639: Support Plugin Arguments
Support Plugin Arguments
Support Plugin Arguments
Support Plugin Arguments
Signed-off-by: thandayuthapani thandayuthapani.s@huawei.com
What this PR does / why we need it:
Support Plugin Arguments
Which issue(s) this PR fixes
Fixes #637